Meaning of optional segment

[thomasp85]

Hi

I'm currently building an R binding for path-tree and during testing I came to the realisation that my understanding of the :name? pattern is flawed, or the implementation broken.

What I observe:

comparing /test/:me and /test/:me?, only the latter matches to /test/ which is what I would expect.

comparing /test/:me/now and /test/:me?/now, none of them matches to /test/now and both matches to /test//now. I would assume the latter would match to /test/now, or the former wouldn't match to /test//now but they seem identical

is this a bug, or if not, what is the differentiator for the two patterns?

[fundon]

Thank you for the feedback.
The document needs to be improved.

comparing /test/:me and /test/:me?, only the latter matches to /test/ which is what I would expect.

/test/:me matches a single path segment (excluding /), and the parameter is required.
/test/:me? is optional.

/test/ will be matched to /test/:me?.

comparing /test/:me/now and /test/:me?/now, none of them matches to /test/now and both matches to /test//now. I would assume the latter would match to /test/now, or the former wouldn't match to /test//now but they seem identical

First, we should remove the redundant / in the input path.

Yea, thank you, find a little bug.

/test//now should be matched to /test/:me?/now.

I've added a test case, you can take a look #46

[thomasp85]

Thanks for this! Is it understood correctly that there is no syntax that would make a single element (including the terminating /) optional, i.e. there is no syntax that would match test/this/now and test/now without also matching e.g. test/multiple/paths/now?

[fundon]

I've updated the test case.

We can use + or * to match multiple path segments. More details.

https://github.com/viz-rs/path-tree/pull/46/files#diff-6b577c9a34766ccdaecd266ae93feb8510e3ce597fe96a35467f8ae06df0e930R10-R12