Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor User: authenticationProviders, secondFactorProviders and validAuthenticationMethods #1127

Open
phorward opened this issue Mar 28, 2024 · 0 comments
Labels
help wanted Extra attention is needed Priority: Medium This issue may be useful, and needs some attention. refactoring Pull requests that refactor code but do not change its behavior.

Comments

@phorward
Copy link
Member

During development of #1125 I found that the definition of the authentication methods in user.py is split into the attributes

  • authenticationProviders
  • secondFactorProviders
  • validAuthenticationMethods

but at least, the only true definition should be just in validAuthenticationMethods; Why should I register an auth_userpassword-login, when validAuthenticationMethods does only define GoogleLogin?

This is a relict and bad extension of old code base, and must be refactored.

@phorward phorward added help wanted Extra attention is needed Priority: Medium This issue may be useful, and needs some attention. refactoring Pull requests that refactor code but do not change its behavior. labels Mar 28, 2024
@phorward phorward added this to the ViUR-core v3.7 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Priority: Medium This issue may be useful, and needs some attention. refactoring Pull requests that refactor code but do not change its behavior.
Projects
None yet
Development

No branches or pull requests

1 participant