Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #249

Open
sheremet-va opened this issue Feb 19, 2024 · 5 comments
Open

Add tests #249

sheremet-va opened this issue Feb 19, 2024 · 5 comments
Assignees
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)

Comments

@sheremet-va
Copy link
Member

sheremet-va commented Feb 19, 2024

Currently, we only have unit tests for some of the functionality, but it would be nice to also have integration tests using Electron API to catch regressions: https://code.visualstudio.com/api/working-with-extensions/testing-extension

@sheremet-va sheremet-va added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 19, 2024
@MilanKovacic
Copy link
Collaborator

I can take this one.

@ffMathy
Copy link
Collaborator

ffMathy commented Feb 24, 2024

Sorry, didn't see this issue. I already have a PR that works for this. See the referenced PR.

@MilanKovacic
Copy link
Collaborator

No problem, I will add a smoke end-to-end test instead.

@sheremet-va
Copy link
Member Author

No problem, I will add a smoke end-to-end test instead.

Yeah, this issue is about integration/e2e tests for the extension to catch regressions earlier.

@sheremet-va
Copy link
Member Author

I added a "needs test" label. Anyone who wants to help, can look through all issues with that label and write a test 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

No branches or pull requests

3 participants