Skip to content

Commit d0244fe

Browse files
Merge pull request #1766 from michael-berlin/worker_pack_count_revert
vtworker: Revert --destination_pack_count to 10.
2 parents 0776485 + eb2bed4 commit d0244fe

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

go/vt/worker/defaults.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,13 @@ import "github.com/youtube/vitess/go/vt/throttler"
88

99
const (
1010
defaultSourceReaderCount = 10
11-
// defaultDestinationPackCount is the number of rows which will be aggreated
12-
// into one transaction. Note that higher values will increase memory
13-
// consumption in vtworker, vttablet and mysql.
14-
defaultDestinationPackCount = 1000
11+
// defaultDestinationPackCount is the number of StreamExecute responses which
12+
// will be aggreated into one transaction. See the vttablet flag
13+
// "-queryserver-config-stream-buffer-size" for the size (in bytes) of a
14+
// StreamExecute response. As of 06/2015, the default for it was 32 kB.
15+
// Note that higher values for this flag --destination_pack_count will
16+
// increase memory consumption in vtworker, vttablet and mysql.
17+
defaultDestinationPackCount = 10
1518
defaultMinTableSizeForSplit = 1024 * 1024
1619
defaultDestinationWriterCount = 20
1720
defaultMinHealthyRdonlyTablets = 2

0 commit comments

Comments
 (0)