From a41541a00e2b239e69815d3ee59e9fc6984ac5ee Mon Sep 17 00:00:00 2001 From: Florent Poinsard Date: Fri, 31 Jan 2025 16:57:12 -0600 Subject: [PATCH] add comment Signed-off-by: Florent Poinsard --- go/vt/vtgate/executorcontext/vcursor_impl.go | 1 + 1 file changed, 1 insertion(+) diff --git a/go/vt/vtgate/executorcontext/vcursor_impl.go b/go/vt/vtgate/executorcontext/vcursor_impl.go index 8e6370eada5..16d2cf196d0 100644 --- a/go/vt/vtgate/executorcontext/vcursor_impl.go +++ b/go/vt/vtgate/executorcontext/vcursor_impl.go @@ -794,6 +794,7 @@ func (vc *VCursorImpl) ExecuteMultiShard(ctx context.Context, primitive engine.P atomic.AddUint64(&vc.logStats.ShardQueries, uint64(noOfShards)) err := vc.markSavepoint(ctx, rollbackOnError && (noOfShards > 1), map[string]*querypb.BindVariable{}) if err != nil { + // this may be a bit too aggressive, maybe we just want to rollback if we receive a VT15001 error. vc.setRollbackOnPartialExecIfRequired(true, rollbackOnError) return nil, []error{err} }