Skip to content

Commit 4ce2b60

Browse files
committed
Update to the new library APIs
Signed-off-by: Dirkjan Bussink <[email protected]>
1 parent 1864056 commit 4ce2b60

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed

go/cmd/vtclient/cli/vtclient.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929
"time"
3030

3131
"github.com/olekukonko/tablewriter"
32+
"github.com/olekukonko/tablewriter/tw"
3233
"github.com/spf13/cobra"
3334
"github.com/spf13/pflag"
3435

@@ -395,10 +396,11 @@ func (r *results) print(w io.Writer) {
395396
return
396397
}
397398

398-
table := tablewriter.NewWriter(os.Stdout)
399-
table.SetHeader(r.Fields)
400-
table.SetAutoFormatHeaders(false)
401-
table.AppendBulk(r.Rows)
399+
table := tablewriter.NewTable(os.Stdout,
400+
tablewriter.WithHeaderAutoFormat(tw.Off),
401+
)
402+
table.Header(r.Fields)
403+
table.Bulk(r.Rows)
402404
table.Render()
403405
fmt.Fprintf(w, "%v row(s) affected (%v, cum: %v)\n", r.rowsAffected, r.duration, r.cumulativeDuration)
404406
if r.lastInsertID != 0 {

go/cmd/vtctldclient/cli/query.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"io"
2121

2222
"github.com/olekukonko/tablewriter"
23+
"github.com/olekukonko/tablewriter/tw"
2324

2425
"vitess.io/vitess/go/sqltypes"
2526
)
@@ -31,15 +32,15 @@ func WriteQueryResultTable(w io.Writer, qr *sqltypes.Result) {
3132
return
3233
}
3334

34-
table := tablewriter.NewWriter(w)
35-
table.SetAutoFormatHeaders(false)
36-
35+
table := tablewriter.NewTable(w,
36+
tablewriter.WithHeaderAutoFormat(tw.Off),
37+
)
3738
header := make([]string, 0, len(qr.Fields))
3839
for _, field := range qr.Fields {
3940
header = append(header, field.Name)
4041
}
4142

42-
table.SetHeader(header)
43+
table.Header(header)
4344

4445
for _, row := range qr.Rows {
4546
vals := make([]string, 0, len(row))

go/vt/wrangler/vexec_plan.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
"strings"
2323

2424
"github.com/olekukonko/tablewriter"
25+
"github.com/olekukonko/tablewriter/tw"
2526

2627
"vitess.io/vitess/go/vt/log"
2728
"vitess.io/vitess/go/vt/sqlparser"
@@ -92,16 +93,19 @@ func (p vreplicationPlanner) dryRun(ctx context.Context) error {
9293
p.vx.wr.Logger().Printf("Query: %s\nwill be run on the following streams in keyspace %s for workflow %s:\n\n",
9394
p.vx.plannedQuery, p.vx.keyspace, p.vx.workflow)
9495
tableString := &strings.Builder{}
95-
table := tablewriter.NewWriter(tableString)
96-
table.SetHeader([]string{"Tablet", "ID", "BinLogSource", "State", "DBName", "Current GTID"})
96+
97+
table := tablewriter.NewTable(tableString,
98+
tablewriter.WithRendition(tw.Rendition{Settings: tw.Settings{Separators: tw.Separators{BetweenRows: tw.On}}}),
99+
tablewriter.WithRowMergeMode(tw.MergeNone),
100+
)
101+
102+
table.Header([]string{"Tablet", "ID", "BinLogSource", "State", "DBName", "Current GTID"})
97103
for _, primary := range p.vx.primaries {
98104
key := fmt.Sprintf("%s/%s", primary.Shard, primary.AliasString())
99105
for _, stream := range rsr.ShardStatuses[key].PrimaryReplicationStatuses {
100106
table.Append([]string{key, fmt.Sprintf("%d", stream.ID), stream.Bls.String(), stream.State, stream.DBName, stream.Pos})
101107
}
102108
}
103-
table.SetAutoMergeCellsByColumnIndex([]int{0})
104-
table.SetRowLine(true)
105109
table.Render()
106110
p.vx.wr.Logger().Printf(tableString.String())
107111
p.vx.wr.Logger().Printf("\n\n")

0 commit comments

Comments
 (0)