Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explanation of what SSR external/noExternal means #15847

Closed
1 of 4 tasks
mkilpatrick opened this issue Feb 8, 2024 · 1 comment · Fixed by #18375
Closed
1 of 4 tasks

Better explanation of what SSR external/noExternal means #15847

mkilpatrick opened this issue Feb 8, 2024 · 1 comment · Fixed by #18375
Labels
documentation Improvements or additions to documentation

Comments

@mkilpatrick
Copy link

Documentation is

  • Missing
  • Outdated
  • Confusing
  • Not sure?

Explain in Detail

It would be helpful for the SSR external/noExternal options to explain what that really means in more detail. What does a noExternal dependency really mean? Does it mean the dependency is transformed by Vite? If so, what are the transformations? Is it the same as optimizeDeps? The optimizeDeps documentation is good as it explains what it's doing and its purpose.

Additionally, does external/noExternal affect dev only or also build? I think adding a little more to the docs here would be helpful for newer users.

Your Suggestion for Changes

See above

Reproduction

No response

Steps to reproduce

No response

@mkilpatrick mkilpatrick added the documentation Improvements or additions to documentation label Feb 8, 2024
@sapphi-red
Copy link
Member

It has a link to https://vite.dev/guide/ssr.html#ssr-externals and that page describes a bit more in detail.

Additionally, does external/noExternal affect dev only or also build?

It applies to both dev and build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants