Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests #47

Open
yifanlu opened this issue Sep 24, 2016 · 3 comments
Open

Unit Tests #47

yifanlu opened this issue Sep 24, 2016 · 3 comments

Comments

@yifanlu
Copy link
Contributor

yifanlu commented Sep 24, 2016

Unit tests and regressions would be nice.

@xyzz
Copy link
Contributor

xyzz commented Nov 27, 2016

How should unit test work? Should we try to load resulting velf with something like uvloader and test bytes in memory? So to ensure relocs apply correctly, for example.

@yifanlu
Copy link
Contributor Author

yifanlu commented Nov 29, 2016

I think basic tests just involve a gold master velf and the generated velf and check that certain properties/sections match.

@yifanlu
Copy link
Contributor Author

yifanlu commented Nov 29, 2016

Ex: we fixed a bug with some layout/alignment. The test would be the input ELF, and we have a GM output velf and the generated velf. Then we just check that the offsets of the sections match and the order of the sections match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants