Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation skipped #177

Open
Tazkazz opened this issue Jul 22, 2018 · 0 comments
Open

Validation skipped #177

Tazkazz opened this issue Jul 22, 2018 · 0 comments

Comments

@Tazkazz
Copy link

Tazkazz commented Jul 22, 2018

On this line of code there's validation for fmt to be a string:

node-progress/lib/node-progress.js

Line 54 in 30d70d9

if ('string' != typeof fmt) throw new Error('format required');

But if the second argument, passed to constructor, is a number (total), this validation is skipped and, later on, the rendering fails.
zhizhuxialiwen pushed a commit to zhizhuxialiwen/node-progress that referenced this issue Dec 11, 2020
@fredgan
Fix: modified :total type to positive integer
fe51435 
The input `:total` value is float, but the output `:current` value is more than `:total` value. The input `:total` is nagative integer or zero, but the output rendering failed.

Closes visionmedia#177, visionmedia#166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tazkazz