Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Improving ClipSpace performance #1203

Open
5 tasks done
mattes3 opened this issue Aug 16, 2019 · 2 comments
Open
5 tasks done

RFC: Improving ClipSpace performance #1203

mattes3 opened this issue Aug 16, 2019 · 2 comments

Comments

@mattes3
Copy link

mattes3 commented Aug 16, 2019

Background

luma's ClipSpace currently works with 2 triangles that form a square. Other frameworks (e.g. gl-react) use one big triangle, instead. There even is an npm component called a-big-triangle that shows this idea. It points to a blog post that claims that one triangle is about 8% faster than 2 triangles and leads better results.

I'm NOT an expert who could judge this difference or who could change the code correctly, therefore, a question to y'all:

  • Do you find it worthwhile to replace the 2 triangles by 1? Maybe it would make luma.gl faster.

To Do List

  • Add label and assign to milestone
  • Coding
  • Doc update
  • Whats new update
  • Test
@tsherif
Copy link
Contributor

tsherif commented Aug 16, 2019

This is quite interesting! Thank you for the references. It should be easy to run benchmarks on a few different hardware setups to see if it's worth making the change.

@ibgreen
Copy link
Collaborator

ibgreen commented Aug 16, 2019

Yes, could be worth a look. I seem to remember considering using a single larger triangle, but opted for using two perfectly fitted triangles instead. No strong reasons I believe, I was mainly focused on getting things functionally correct, didn't do any benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants