Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix css/js errors in console #141

Open
nathan-schmidt-viget opened this issue Jul 31, 2024 · 0 comments
Open

Fix css/js errors in console #141

nathan-schmidt-viget opened this issue Jul 31, 2024 · 0 comments
Assignees
@nathan-schmidt-viget

Comments

@nathan-schmidt-viget
Copy link
Contributor

nathan-schmidt-viget commented Jul 31, 2024 •
edited
Loading

Console log error

With the new version of WP there is now a script with type="importmap" and our script has type="module" and type module can not come before any importmap types.
This can be fixed in the class-vite.php by setting 100 for wp_head.

add_action( 'wp_head', [ $this, 'init' ], 100 );

Vite twise

We are also calling Vite() twice which is loading everything twice.

Classes missing in preview

Remove is_preview() from acf-blocks-toolkit/includes/helpers.php
@nathan-schmidt-viget nathan-schmidt-viget self-assigned this Jul 31, 2024
@nathan-schmidt-viget nathan-schmidt-viget changed the title Making custom css/js the last thing in the head Fix css/js errors in console Jul 31, 2024
nathan-schmidt-viget added a commit that referenced this issue Aug 1, 2024
@nathan-schmidt-viget
[#141] Fixing css/js bugs with preview and console log
7ccbb2e
@nathan-schmidt-viget nathan-schmidt-viget mentioned this issue Aug 5, 2024
Merged
bd-viget pushed a commit that referenced this issue Sep 10, 2024
@nathan-schmidt-viget
[#141] Fixing css/js bugs with preview and console log (#142)
94eb448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathan-schmidt-viget nathan-schmidt-viget

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nathan-schmidt-viget