-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please let me reorganize the events on the docs page #8893
Comments
👋 Thanks for opening your first issue here! 👋 If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
A PR would be appreciated, but I'm not sure how easy and maintainable it would be to change since this is all generated from jsdoc. |
@gkatsev thanks for replaying. I will keep that in mind while trying to figure out a solution for this. What tooling do you guys use to generate the docs from JSDoc? |
Line 72 in d2b9d5c
The jsdoc config here: https://github.com/videojs/video.js/blob/main/.jsdoc.js The theme is https://github.com/ankitskvmdam/clean-jsdoc-theme. The theme author was very responsive to another issue I raised, if it's something that needs to be addressed there. |
@mister-ben and @gkatsev It seems someone already opened the issue/request to have better content structuring in the sidebar ankitskvmdam/clean-jsdoc-theme#203. I will try to update our underlying dependency which is Hopefully this way we can just indicate in what subcategory each Event belongs to. For example adding the
This seems as an clear and intuitive way to update the docs without breaking anything currently that is the VideoJS docs. |
Description
The current docs page is really confusing and hard to navigate. If possible I want to make only small adjustments to it where the events are listed under the appropriate section. So that we don't have multiple
tap
events but<section> – tap
or<section>:tap
which is much easier to read.I just need the node of approval from a maintainer here and I will create a PR for this.
Thank you for working on VideoJS as it is the backbone of many videos on the internet <3
Reduced test case
https://docs.videojs.com/
Steps to reproduce
Errors
No errors.
What version of Video.js are you using?
8.19.1
Video.js plugins used.
None
What browser(s) including version(s) does this occur with?
Arc – Chromium 129.0.6668.101 (Official Build) (arm64)
What OS(es) and version(s) does this occur with?
macOS 14.7
The text was updated successfully, but these errors were encountered: