Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting QMK_SETTINGS to yes seems to reset AUTO_SHIFT_ENABLE to no #765

Open
andruhon opened this issue Aug 4, 2024 · 2 comments
Open

Comments

@andruhon
Copy link

andruhon commented Aug 4, 2024

I have the following rules.mk in my layout

VIA_ENABLE          = yes
VIAL_ENABLE         = yes
LTO_ENABLE          = yes

# Enabling QMK settings takes control over things like AUTO_SHIFT_ENABLE
# I didn't yet figured out how to provide defaults for these QMK settings
QMK_SETTINGS        = yes
AUTO_SHIFT_ENABLE 	= yes

RGBLIGHT_ENABLE     = no
RGB_MATRIX_ENABLE   = no # Can't have RGBLIGHT and RGB_MATRIX at the same time.
MOUSEKEY_ENABLE     = yes
OLED_ENABLE         = yes
EXTRAKEY_ENABLE     = no
COMBO_ENABLE        = no

When QMK_SETTINGS is no, autoshift works as expected, once QMK_SETTINGS is enabled it does not work after flashing and has to be enabled from UI.
image

I would expect the default configuration to be picked up.

@Solodros
Copy link

Solodros commented Sep 5, 2024

https://github.com/vial-kb/vial-qmk/blob/vial/quantum/qmk_settings.c#L165,Change QS.auto_shift = 0; to QS.auto_shift = 1;

@andruhon
Copy link
Author

Thank you @Solodros ! This change seems to solve the issue.
I have created a PR using AUTO_SHIFT_ENABLE instead of 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants