Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksops breaks kustomize localize #179

Open
Striar-Yunis opened this issue May 11, 2023 · 3 comments
Open

ksops breaks kustomize localize #179

Striar-Yunis opened this issue May 11, 2023 · 3 comments

Comments

@Striar-Yunis
Copy link

Generators need to report back what files they reference so that kustomize localize can gather the appropriate files. See the work done for the builtin configmap generator and secret generator here. Thanks for all your hard work on this.
@devstein
Copy link
Collaborator

devstein commented May 17, 2023 •
edited
Loading

Hi @Striar-Yunis thanks for the heads up. Happy to fix, but It's non-obvious to me what code changes are required from the PR you linked. Do you mind sharing a bit more information/context?

@Striar-Yunis
Copy link
Author

Sorry I should have posted back again here. I did some further investigating and the hooks needed to do this aren't yet available. When they are, I'll try to generate a PR. kubernetes-sigs/kustomize#4996 (comment)

@devstein
Copy link
Collaborator

Great, thanks @Striar-Yunis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devstein @Striar-Yunis