Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLS install failing, existing RLS not found #87

Open
leavengood opened this issue Mar 29, 2018 · 1 comment
Open

RLS install failing, existing RLS not found #87

leavengood opened this issue Mar 29, 2018 · 1 comment

Comments

@leavengood
Copy link

So it seems the way RLS is supposed to be installed has changed recently. In Tokamak 0.4.1 I was getting console errors when trying to install the RLS:

Uncaught (in promise) Error: Command failed: /Users/leavengood/.cargo/bin/rustup component add rls --toolchain nightly
error: toolchain 'nightly-x86_64-apple-darwin' does not contain component 'rls' for target 'x86_64-apple-darwin'

I then followed the instructions on https://github.com/rust-lang-nursery/rls to manually install RLS using rustup, but not on nightly, on the stable channel. Therefore since Tokamak is trying to run the RLS with the nightly toolchain, it could not run:

https://github.com/vertexclique/tokamak/blob/master/lib/rls.js#L153

I got the RLS working in Tokamak by commenting out the contents of checkRLS() and just returning a resolved Promise, and changing the above nightly cargo parameter to stable.

I am not sure of the proper solution, otherwise I might consider a PR.

Otherwise I found hacking on Tokamak pretty easy!

@leavengood
Copy link
Author

This is with these versions:
Atom 1.25.0, Rust 1.24.1, rustup 1.11.0, Cargo 0.25.0 on Mac OS X 10.10.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant