Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove corepack upgrade step from corepack build target #1668

Merged
merged 2 commits into from
Aug 11, 2022

Commits on Aug 10, 2022

  1. Remove corepack upgrade step from corepack build target

    The corepack step as it exists causes issues if a machine already has corepack enabled and is using the npm shim:
    ```
    olszewski@chriss-mbp cli % make corepack
    npm install -g corepack@latest
    Usage Error: This project is configured to use pnpm
    
    $ npm ...
    make: *** [corepack] Error 1
    ```
    
    I think we could get around this by changing to a working directory without a packageManager, but that feels very icky.  Since we were only upgrading corepack in order to avoid [#110](nodejs/corepack#110) which only happens the first time a user sets up a package manager on a machine, I think this an acceptable regression in order to unblock development.
    
    We should follow what comes out of [vercel#157](nodejs/corepack#157) to see if we can add this back eventually.
    chris-olszewski committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    7f92a1f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Configuration menu
    Copy the full SHA
    704a9a5 View commit details
    Browse the repository at this point in the history