Skip to content

Commit 7f92a1f

Browse files
Remove corepack upgrade step from corepack build target
The corepack step as it exists causes issues if a machine already has corepack enabled and is using the npm shim: ``` olszewski@chriss-mbp cli % make corepack npm install -g corepack@latest Usage Error: This project is configured to use pnpm $ npm ... make: *** [corepack] Error 1 ``` I think we could get around this by changing to a working directory without a packageManager, but that feels very icky. Since we were only upgrading corepack in order to avoid [#110](nodejs/corepack#110) which only happens the first time a user sets up a package manager on a machine, I think this an acceptable regression in order to unblock development. We should follow what comes out of [#157](nodejs/corepack#157) to see if we can add this back eventually.
1 parent e31a9ab commit 7f92a1f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

cli/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ install: | ./package.json
6767
pnpm install --filter=cli
6868

6969
corepack:
70-
npm install -g corepack@latest
70+
which corepack || npm install -g corepack@latest
7171
corepack enable
7272

7373
e2e: corepack install turbo

0 commit comments

Comments
 (0)