Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error approving new entry #77

Closed
effer89 opened this issue Jul 23, 2019 · 12 comments
Closed

Error approving new entry #77

effer89 opened this issue Jul 23, 2019 · 12 comments

Comments

@effer89
Copy link

effer89 commented Jul 23, 2019

Description

Getting Request missing required body param when trying to approve an submission.

Steps to reproduce

  1. Approve any submission

Additional info

  • Plugin version: 1.2.1
  • Craft version: Craft Pro 3.2.5.1
@mattrothenberg
Copy link

Confirmed and likely related to #76.

@engram-design
Copy link
Member

Should be fixed in 1.2.2.

@martyspain
Copy link

I'm still experiencing this issue on Craft 3.2.8 running Workflow 1.2.2, with existing entries that are Pending. On clicking 'Approve and publish' I get the 'missing body param' error.

@engram-design engram-design reopened this Aug 6, 2019
@engram-design
Copy link
Member

@martyspain Can you provide the full error? Struggling to reproduce this no matter what I try!

@martyspain
Copy link

@engram-design I've just tested approving and publishing an entry again and here's the full error line from our web.log file in production:

2019-08-08 13:11:50 [-][1][874b3fss90jpk20s4oq15sa9ao][error][yii\web\HttpException:400] yii\web\BadRequestHttpException: Request missing required body param in /var/app/current/vendor/craftcms/cms/src/web/Request.php:656

I can run an environment up in devMode if you need more information than that?

@martyspain
Copy link

I've done another test on a draft submitted after the recent update to Workflow 1.2.2 and that can be published with no problems, so maybe my issue is with old Workflow submissions that were created pre-update. Does this help in any way?

@engram-design
Copy link
Member

@martyspain Ah, yes that helps! I'll see what I can do to scrounge together some examples to test. We've been buffeted around a bit after the latest 3.2.x changes (which changed a few times!)

@martyspain
Copy link

If you'd like a database dump or any further info, I'm happy to provide whatever help I can! Thanks for looking into this - I realise it's a horrible edge case :)

@engram-design
Copy link
Member

No need to apologise. Are you on the Discord? If so, my handle is crawf. Happy to touch base there as a database dump would be super helpful

@effer89
Copy link
Author

effer89 commented Aug 8, 2019

Still having the same problems :/

I've done another test on a draft submitted after the recent update to Workflow 1.2.2 and that can be published with no problems, so maybe my issue is with old Workflow submissions that were created pre-update. Does this help in any way?

I have problems approving new workflow entries, not just old ones also.

Thanks!

Plugin version: 1.2.2
Craft version: Craft Pro 3.2.9

@engram-design
Copy link
Member

Still unable to reproduce on new or existing approvals. @effer89 Would you be able to share the full stack trace error with devMode on?

Can you also let me know the URL that you're trying to approve items on? It should contain at least the ?draftId=x value.

@engram-design
Copy link
Member

Should be fixed in 1.2.3. Thanks @mattrothenberg for your time with this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants