Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second Reviewer User Group not able to approve and reject a draft #214

Closed
yeboJoseph opened this issue Aug 2, 2024 · 2 comments
Closed

Comments

@yeboJoseph
Copy link

yeboJoseph commented Aug 2, 2024

Describe the bug

  1. Editor creates Draft
  2. First Reviewer User Group approves Draft
  3. Second Reviewer User Group accesses draft edit page, but only sees the "Awaiting approval".
    workflow

Also, I would assume the publisher would get a notification to approve a draft after the second reviewer has submitted they're approval. Currently after the first reviewer as approved the draft, the publisher gets a notification to approve.

Steps to reproduce

  1. Editor creates draft and submits for approval
  2. First reviewer approves draft
  3. Second reviewer goes to view entry and doesn't have the option to approve or reject

Craft CMS version

4.10.7

Plugin version

2.0.11

Multi-site?

Yes

Additional context

No response

@engram-design
Copy link
Member

Can you comment if there's any overlap between user groups for the users? I don't see that behaviour on my end (quick video below shows the process with 2 reviewer groups).

CleanShot.2024-08-04.at.10.25.15.mp4

As for the email, I again can't replicate that. The only issue I see is that the editor currently gets notified when each reviewer approves their entry. They probably shouldn't, as although it's been approved, the editor probably doesn't care if each reviewer approves their submission. They mostly care about the final publisher approval. Although maybe we just introduce another email for reviewer-approved.

@yeboJoseph
Copy link
Author

Yup, there was an overlap between reviewer and editor. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants