Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed Me integration not accounting for extensions on Vizy field #289

Open
robmcfadden opened this issue Mar 11, 2024 · 2 comments
Open

Feed Me integration not accounting for extensions on Vizy field #289

robmcfadden opened this issue Mar 11, 2024 · 2 comments

Comments

@robmcfadden
Copy link

Describe the bug

We have added an extension to Vizy to allow for id attributes on HTML elements per the comment here: "The way around this - while a little more work - is to create an extension for Tiptap that adds this allowed attribute to the Paragraph node."

This works for us when saving content manually in Craft, but not when importing content with id attributes on HTML elements through Feed Me. I believe the Feed Me integration just doesn't know about that custom extension and so isn't preserving those id attributes. Is there a way to account for this in the plugin?

Steps to reproduce

  1. Add a Vizy extension, specifically one that is extending tiptap in our case
  2. Import content through Feed Me that depends on that extension

Craft CMS version

Craft Pro 4.8.0

Plugin version

2.1.15

Multi-site?

Yes

Additional context

No response

@engram-design
Copy link
Member

Good point, we should probably be incorporating things into the Feed Me editor instance.

Just wanted to confirm how you're registering your extensions though. Unless you're using Nodes::EVENT_REGISTER_NODE to register a custom node, the extension will only be a JS-class, which is used by the editor. We would need to have the same extension behaviour created and applied in PHP which would introduce a new event to register extensions.

@robmcfadden
Copy link
Author

Got it, that makes sense. It is just a JS-class. I can resolve this for my situation outside of the Feed Me feed. It's a one-time feed and then content updates can resume in the entry itself where the Vizy/Tiptap extension works as expected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants