Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignored param 'aws_no_reboot_on_create_ami' #5

Open
webroru opened this issue Jun 8, 2018 · 1 comment
Open

ignored param 'aws_no_reboot_on_create_ami' #5

webroru opened this issue Jun 8, 2018 · 1 comment

Comments

@webroru
Copy link

webroru commented Jun 8, 2018

Hello,
First off all, thanks for new features for capistrano-elbas fork!

I found a couple bugs.. I'll try to describe them in separate issues.

capistrano-asg/lib/capistrano/asg/ami.rb

Line 22 in 147bbbc

no_reboot: fetch(:aws_no_reboot_on_create_ami, true)

You fetch :aws_no_reboot_on_create_ami from the global scope but it should be in region params according you readme. It's a little confusing.
@webroru webroru mentioned this issue Jun 8, 2018
Open
@webroru
Copy link
Author

webroru commented Apr 23, 2019

Hello?? @sixfeetover, any reason why my fix can't be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@webroru