Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

venveo / craft-oauthclient Public

Notifications You must be signed in to change notification settings
Fork 3
Star 9

Code
Issues 18
Pull requests 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Craft 4 #43

Draft

Mosnar wants to merge 11 commits into main

base: main

Choose a base branch

Loading

Loading

from develop

Draft

Craft 4 #43

Mosnar wants to merge 11 commits into main from develop

Conversation 0 Commits 11 Checks 0 Files changed

Conversation

Copy link

Contributor

Mosnar commented Aug 12, 2022 •

edited

Loading

To Do:

Adjust token storage to store only latest valid token for a particular app & user (Fixes FR: Auto-token purging #11)
Fix When Resource Server withdraws AccessToken renderConnector() doesn't know and users can't authorize again #39
Fix credentials->getValidTokensForAppAndUser() returns all tokens when nobody is logged in #38
Fix Typos in code in README #36
Fix Front end OAuth authorization only works when 'Access the control panel' permission is set #35

Wishlist:

Fix FR: client credentials #40
Fix How to remove tokens from within the cp? from the console? and by php? #34, Fix FR: Improved UX for viewing tokens #6

Done

Update for Craft 4 (Fixes Craft 4 version #42)
Fix editable table for scopes
Check dependencies for updates
Update datetime casting in models
Fix unhandled php error on saving app with empty scopes list #37

Sorry, something went wrong.

bzin reacted with eyes emoji

All reactions

👀 1 reaction

Mosnar added 11 commits

August 12, 2022 09:56


          Initial Craft 4 refactor (untested)

f97bdf9


          Update editable table field for Craft 4

87ffa06


          Code cleanup

978c89f


          Fix error caused by removing isNew property from App model

b2d8dc4


          More docs & return types

4c21ff5


          Fix some type issues

35dceea


          Better return types

4d93d72


          Tidier

7ff4f74


          Update Google oauthclient minimum version

e1070bb


          Fix error when saving an app with no scopes (Fixes #37)

f870d12


          Remove userId from apps

0d0ce04

bzin mentioned this pull request

Craft 4 version #42

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typos in code in README Front end OAuth authorization only works when 'Access the control panel' permission is set How to remove tokens from within the cp? from the console? and by php? FR: Auto-token purging FR: Improved UX for viewing tokens

unhandled php error on saving app with empty scopes list credentials->getValidTokensForAppAndUser() returns all tokens when nobody is logged in When Resource Server withdraws AccessToken renderConnector() doesn't know and users can't authorize again FR: client credentials Craft 4 version

1 participant

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.