Skip to content
This repository has been archived by the owner on Mar 21, 2019. It is now read-only.

Add verify authentication code functionality for observing wallet in VeChainThor mobile wallet #4

Open
DaveBeer opened this issue Aug 5, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@DaveBeer
Copy link

DaveBeer commented Aug 5, 2018

When importing observing wallet on VeChainThor mobile wallet v1.1.0, authentication code must be signed by private key of the observed wallet. If one wants to observe wallet created in thor-sync, there is currently no way how to sign the authentication code in thor-sync, in order to prove that you own the observed wallet. I suppose the only way would be to export private key and use it to sign the code outside thor-sync, but that would decipher the private key and expose it in raw way.

Would you please consider adding functionality to thor-sync, which would allow signing the authentication code a display signed message also with QR code for easy scan in VeChainThor mobile wallet?

Alternatively more generally, would you consider adding functionality to sign any message by the private key as is often available in other wallets, not just limited to authentication code for importing observing wallet? This can be used to prove ownership of wallet in safe manner for any purpose.

@XJWX89
Copy link
Contributor

XJWX89 commented Aug 7, 2018

@suiri thanks for the suggestion, we will consider this function.

@XJWX89 XJWX89 added the enhancement New feature or request label Aug 7, 2018
@cchen408
Copy link

cchen408 commented Aug 7, 2018

I'm confused.. observing a wallet shouldn't require a private key. The blockchain is public and you're just keeping track of a wallet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants