Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RKDA and RKDA-E define excessive center coordinates for FIR boundary #689

Open
dneuge opened this issue Jun 25, 2023 · 1 comment
Open
Labels
help wanted Extra attention is needed

Comments

@dneuge
Copy link

dneuge commented Jun 25, 2023

Generated FIRBoundaries.dat contain the following lines:

RKDA|0|0|67|32.5|124|38.6361|133.647211|105.143991|128.290184
RKDA-E|0|0|22|35.411667|127.560833|38.6361|133.647211|120.689693|128.530449

The second-last value is supposed to be the latitude of the FIR's center point according to documentation. If liberally interpreted 105.14°N and 120.69°N cross the poles (latitudes should not exceed ±90°) which would make those points wrap to the other side of the earth, moving the center coordinate from the original boundary box between South Korea and Japan to in between Greenland and Canada (somewhere around 60°N 52°W).

The error appears to be taken over from label_lat fields in Boundaries.geojson.

@Adrian2k Adrian2k added the help wanted Extra attention is needed label Mar 29, 2024
@ziplock1
Copy link
Contributor

ziplock1 commented Jan 7, 2025

Hello. This one was fixed in #692 and looks clear

RKDA|0|0|64|33.625556|124|38.6361|133.647211|36.867630|128.898325

RKDA-E|0|0|22|35.411667|127.560833|38.6361|133.647211|37.354933|130.240947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants