Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #129

Closed
variar opened this issue Nov 14, 2019 · 14 comments
Closed

Dark theme #129

variar opened this issue Nov 14, 2019 · 14 comments

Comments

@variar
Copy link
Owner

variar commented Nov 14, 2019

Consider providing dark theme variant like one from lengocthuong15/dark-klogg@b623d0e

@variar variar added this to the 2020.next milestone Nov 14, 2019
@variar
Copy link
Owner Author

variar commented Dec 30, 2019

Also checkout qdarkstyle from sergei-dyshel/glogg@c144d00

@johnsonzhuangsh
Copy link

Waiting on this.

@variar
Copy link
Owner Author

variar commented May 11, 2020

Fixed some color palette issues and added auto-inversion for icon loading in 1327205.

Klogg now looks ok using either light or dark Breeze themes from KDE. Need more testing in Windows and Mac environments.

@variar variar self-assigned this May 11, 2020
@variar variar modified the milestones: 2020.next, 2020.08 May 11, 2020
@variar
Copy link
Owner Author

variar commented May 12, 2020

Support for windows will be with Qt 5.15. See https://bugreports.qt.io/browse/QTBUG-72028

@variar
Copy link
Owner Author

variar commented May 19, 2020

Same issue in Glogg nickbnf#274

@redfellow
Copy link

Partial dark support can be done via highlighters, but it doesn't indeed resolve the app itself being light.

I hope the Qt issue is resolved soon. If not, perhaps you could add color options to the app itself?

image

@variar
Copy link
Owner Author

variar commented Sep 12, 2020

Switched builds 20.9.+ to Qt 5.15 on Windows. However, looking at Qt BUG 72028 Dark style is still experimental there.

variar added a commit that referenced this issue Sep 24, 2020
@variar
Copy link
Owner Author

variar commented Sep 24, 2020

Added QDarkStyle and combobox to select styles in Tools->Options->View. Should land in 20.9.0.674+.

Click on screenshot for better quality
image

@redfellow
Copy link

redfellow commented Sep 24, 2020

Works for me.

I'm not sure if it's related to enabling the dark mode, but on 20.9.0.680 the highliters no longer work. They worked until I exported, removed, and imported one back. Now I can't get any to highlight anything, and reverting to default theme does not affect it.

Edit: Found I have to enable the highlighter from context menu, so unrelated. Dark mode working fine for the most part 👍

@variar
Copy link
Owner Author

variar commented Sep 24, 2020

There is still much to improve. Contrast is arguably too high and marks outline should be dark. But creating themes is not really my area of expertise. If anyone can suggest better dark stylesheet for qt, I'll be glad to try.

@xhargh
Copy link

xhargh commented Sep 28, 2020

There seems to be an issue in the QDarkSheet that shows itself here also:
ColinDuquesnoy/QDarkStyleSheet#200

image

Tested on a Mac with Catalina 10.15.7

@variar
Copy link
Owner Author

variar commented Sep 28, 2020

QDarkSheet authors recommend using Qt LTS version. I'm thinking about it for CI builds

@variar
Copy link
Owner Author

variar commented Oct 1, 2020

@xhargh Indeed switching to Qt 5.12 on Mac seems to fix this issue with combo-boxes.

@variar
Copy link
Owner Author

variar commented Oct 2, 2020

I'm closing this issue as general request for dark theme is complete. Please open separate issues for any glitches.

@variar variar closed this as completed Oct 2, 2020
@variar variar added status: done and removed status: ready for testing resolved but needs testing labels Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants