Skip to content

Commit 3119ff9

Browse files
vaadin-botZheSun88
andauthored
chore: provide more waiting time in test (#7999) (#8002)
Co-authored-by: Zhe Sun <[email protected]>
1 parent 518a8a9 commit 3119ff9

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

vaadin-platform-react-hybrid-test/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@
189189
<plugin>
190190
<groupId>org.springframework.boot</groupId>
191191
<artifactId>spring-boot-maven-plugin</artifactId>
192+
<version>${spring.boot.version}</version>
192193
<executions>
193194
<execution>
194195
<id>repackage</id>

vaadin-platform-react-hybrid-test/src/test/java/com/vaadin/platform/react/test/HillaMainLayoutIT.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ public void forwardNavigationTest() {
7272
By.id("toHello"));
7373
findElement(By.id("toHello")).click();
7474

75-
Assert.assertTrue("Navigation with NavLink failed.",
76-
$(VerticalLayoutElement.class).id("HelloReact").isDisplayed());
75+
waitForElement("Navigation with NavLink failed.",
76+
By.id("HelloReact"));
7777

7878
// Navigate to Flow view
7979
getMenuElement("Flow in hilla").get().click();
@@ -83,13 +83,13 @@ public void forwardNavigationTest() {
8383
getDriver().navigate().back();
8484
getDriver().navigate().back();
8585

86-
Assert.assertTrue("Should have returned to initial page",
87-
findElement(By.id("toHello")).isDisplayed());
86+
waitForElement("Should have returned to initial page",
87+
By.id("toHello"));
8888

8989
getDriver().navigate().forward();
9090

91-
Assert.assertTrue("Expected hilla view after forward",
92-
$(VerticalLayoutElement.class).id("HelloReact").isDisplayed());
91+
waitForElement("Expected hilla view after forward",
92+
By.id("HelloReact"));
9393

9494
getDriver().navigate().forward();
9595

0 commit comments

Comments
 (0)