-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(file-router): allow routes with the same path #2971
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
==========================================
- Coverage 92.61% 92.52% -0.09%
==========================================
Files 84 84
Lines 3156 3159 +3
Branches 769 770 +1
==========================================
Hits 2923 2923
- Misses 181 184 +3
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @Lodin and @ZheSun88, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually? |
* refactor(file-router): attempt to consider all routes with the same path * refactor(file-router): allow elements with same path in the route list * style(file-router): cleanup * chore: update package-lock.json * test(file-router): fix index fallback assertion * chore: revert package-lock.json * chore(file-router): remove extra dependency * chore(generator-utils): remove unnecessary export * chore: revert package-lock.json * chore(file-router): do not bring old tests back --------- Co-authored-by: Anton Platonov <[email protected]>
…2979) fix(file-router): allow routes with the same path (#2971) * refactor(file-router): attempt to consider all routes with the same path * refactor(file-router): allow elements with same path in the route list * style(file-router): cleanup * chore: update package-lock.json * test(file-router): fix index fallback assertion * chore: revert package-lock.json * chore(file-router): remove extra dependency * chore(generator-utils): remove unnecessary export * chore: revert package-lock.json * chore(file-router): do not bring old tests back --------- Co-authored-by: Vlad Rindevich <[email protected]> Co-authored-by: Anton Platonov <[email protected]>
Fixes #2954.