fix(form): initialize arrays when receiving items #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 24.5 #2959 +/- ##
=======================================
Coverage ? 92.12%
=======================================
Files ? 81
Lines ? 2681
Branches ? 699
=======================================
Hits ? 2470
Misses ? 164
Partials ? 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
cromoteca
approved these changes
Jan 8, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
* fix(form): initialize arrays when receiving items Fixes #2949 * fix(lit-form): make it build * test(lit-form): make linter happy --------- Co-authored-by: Vlad Rindevich <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
* fix(form): initialize arrays when receiving items Fixes #2949 * fix(lit-form): make it build * test(lit-form): make linter happy --------- Co-authored-by: Vlad Rindevich <[email protected]>
cromoteca
pushed a commit
that referenced
this pull request
Jan 8, 2025
…3127) fix(form): initialize arrays when receiving items (#2959) * fix(form): initialize arrays when receiving items Fixes #2949 * fix(lit-form): make it build * test(lit-form): make linter happy --------- Co-authored-by: Anton Platonov <[email protected]> Co-authored-by: Vlad Rindevich <[email protected]>
cromoteca
added a commit
that referenced
this pull request
Jan 13, 2025
…3126) fix(form): initialize arrays when receiving items (#2959) * fix(form): initialize arrays when receiving items Fixes #2949 * fix(lit-form): make it build * test(lit-form): make linter happy --------- Co-authored-by: Anton Platonov <[email protected]> Co-authored-by: Vlad Rindevich <[email protected]> Co-authored-by: Luciano Vernaschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2949
Fixes #3102