chore: rename hilla-file-router to file-router
#2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cromoteca
commented
Mar 25, 2024
| @@ -13,9 +13,6 @@ | |||
| /** | |||
| * Implementation of TypeScript's Hilla ConfigView. Represents a view | |||
| * configuration from Hilla file-system-routing module. | |||
| * | |||
| * @see <a href= | |||
| * "https://github.com/vaadin/hilla/tree/main/packages/ts/hilla-file-router/src/utils.ts#L3">ConfigView</a> | |||
There was a problem hiding this comment.
Link dead before PR
cromoteca
commented
Mar 25, 2024
| @@ -6,7 +6,6 @@ | |||
| * Represents a view's menu configuration | |||
| * from Hilla file-system-routing. | |||
| * Used for configuring MainLayout navigation items | |||
| * @see <a href="https://github.com/vaadin/hilla/tree/main/packages/ts/hilla-file-router/src/utils.ts#L38">ConfigView menu</a> | |||
There was a problem hiding this comment.
Link dead before PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 65 65
Lines 1639 1639
Branches 368 368
=======================================
Hits 1537 1537
Misses 67 67
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cromoteca
changed the title
hilla-file-router to file-routerhilla-file-router to file-router
…ctory-whose-name-does-not-follow-existing-pattern
taefi
previously approved these changes
Mar 26, 2024
…ctory-whose-name-does-not-follow-existing-pattern
|
cromoteca
deleted the
fix/2260/File-router-TS-package-is-in-a-directory-whose-name-does-not-follow-existing-pattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2260