Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(2.5): update internal dependencies stuck to beta #1987

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

cromoteca
Copy link
Contributor

@cromoteca cromoteca commented Jan 25, 2024

This might solve snapshot build errors

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @hilla/[email protected]
npm ERR! Found: @hilla/[email protected]
npm ERR! node_modules/@hilla/form
npm ERR!   workspace packages/ts/form from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @hilla/form@"2.5.6" from @hilla/[email protected]
npm ERR! packages/ts/generator-typescript-plugin-model
npm ERR!   @hilla/[email protected]
npm ERR!   node_modules/@hilla/generator-typescript-plugin-model
npm ERR!     workspace packages/ts/generator-typescript-plugin-model from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @hilla/[email protected]
npm ERR! node_modules/@hilla/form
npm ERR!   peer @hilla/form@"2.5.6" from @hilla/[email protected]
npm ERR!   packages/ts/generator-typescript-plugin-model
npm ERR!     @hilla/[email protected]
npm ERR!     node_modules/@hilla/generator-typescript-plugin-model
npm ERR!       workspace packages/ts/generator-typescript-plugin-model from the root project
npm ERR!

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (2.5@0c3da11). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             2.5    #1987   +/-   ##
======================================
  Coverage       ?   95.04%           
======================================
  Files          ?       51           
  Lines          ?     3388           
  Branches       ?      488           
======================================
  Hits           ?     3220           
  Misses         ?      140           
  Partials       ?       28           
Flag Coverage Δ
unittests 95.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cromoteca cromoteca requested a review from taefi January 25, 2024 07:19
@taefi taefi merged commit 0897d84 into 2.5 Jan 25, 2024
15 checks passed
@taefi taefi deleted the chore/2.5/update-internal-deps branch January 25, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants