Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use snapshots for Flow and TestBench #1951

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Conversation

cromoteca
Copy link
Contributor

@cromoteca cromoteca commented Jan 11, 2024

Set both to 24.4-SNAPSHOT. Other changes are findings while making tests pass.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5d2850) 95.31% compared to head (761cab2) 95.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1951   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          52       52           
  Lines        3479     3479           
  Branches      522      522           
=======================================
  Hits         3316     3316           
  Misses        129      129           
  Partials       34       34           
Flag Coverage Δ
unittests 95.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZheSun88
Copy link
Contributor

i pushed a commit to update the testbench version

@cromoteca cromoteca force-pushed the chore/use-flow-snapshot branch from ec25307 to 9c905c1 Compare January 11, 2024 11:33
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@taefi taefi enabled auto-merge (squash) January 11, 2024 12:35
@taefi taefi merged commit 33dd42c into main Jan 11, 2024
15 checks passed
@taefi taefi deleted the chore/use-flow-snapshot branch January 11, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants