feat: add support for JsonSubTypes

[cromoteca]

Adds a union type for JsonSubTypes.

This is the supported configuration:

@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY)
@JsonSubTypes({
    @JsonSubTypes.Type(value = UpFilter.class, name = "Up"),
    @JsonSubTypes.Type(value = DownFilter.class, name = "Down")}
)
public class Filter {
    public int dummy;
}

Closes #438
Closes #1255

[codecov]

Codecov Report

Patch coverage: 97.24% and project coverage change: +0.08% 🎉

Comparison is base (080a969) 96.18% compared to head (4b09c54) 96.27%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
+ Coverage   96.18%   96.27%   +0.08%     
==========================================
  Files          14       17       +3     
  Lines        1679     1824     +145     
  Branches      139      155      +16     
==========================================
+ Hits         1615     1756     +141     
- Misses         64       68       +4     

Flag	Coverage Δ
unittests	96.27% <97.24%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ypescript-plugin-subtypes/src/ModelFixProcessor.ts	95.00% <95.00%> (ø)
...typescript-plugin-subtypes/src/TypeFixProcessor.ts	96.15% <96.15%> (ø)
...ypescript-plugin-subtypes/src/SubTypesProcessor.ts	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Artur-]

This is what I see from the react-grid-test module

WARN (tsgen) <BackbonePlugin>: Component has no properties:' dev.hilla.mappedtypes.PageableUnion'
WARN (tsgen) <BackbonePlugin>: Component has no properties:' dev.hilla.crud.filter.Filter'
WARN (tsgen) <BackbonePlugin>: Component has no properties:' dev.hilla.test.reactgrid.CompanyUnion'
WARN (tsgen) <BackbonePlugin>: Component has no properties:' dev.hilla.test.reactgrid.PersonUnion'
WARN (tsgen) <BackbonePlugin>: Component has no properties:' dev.hilla.mappedtypes.SortUnion'
WARN (tsgen) <BackbonePlugin>: Component has no properties:' dev.hilla.crud.filter.PropertyStringFilter$MatcherUnion'
WARN (tsgen) <BackbonePlugin>: Component has no properties:' dev.hilla.mappedtypes.OrderUnion'
WARN (tsgen) <BackbonePlugin>: Component has no properties:' org.springframework.data.domain.Sort$DirectionUnion'
WARN (tsgen) <BackbonePlugin>: Component has no properties:' org.springframework.data.domain.Sort$NullHandlingUnion'
WARN (tsgen) <ModelPlugin>: Component has no properties: dev.hilla.mappedtypes.PageableUnion
WARN (tsgen) <ModelPlugin>: Component has no properties: dev.hilla.crud.filter.Filter
ERROR (tsgen) <ModelPlugin>: The schema for a class component dev.hilla.crud.filter.FilterUnion is broken.
    type: "object"
    oneOf: [
      {
        "$ref": "#/components/schemas/dev.hilla.crud.filter.OrFilter"
      },
      {
        "$ref": "#/components/schemas/dev.hilla.crud.filter.AndFilter"
      },
      {
        "$ref": "#/components/schemas/dev.hilla.crud.filter.PropertyStringFilter"
      }
    ]
WARN (tsgen) <ModelPlugin>: Component has no properties: dev.hilla.test.reactgrid.CompanyUnion
WARN (tsgen) <ModelPlugin>: Component has no properties: dev.hilla.test.reactgrid.PersonUnion
WARN (tsgen) <ModelPlugin>: Component has no properties: dev.hilla.mappedtypes.SortUnion
WARN (tsgen) <ModelPlugin>: Component has no properties: dev.hilla.crud.filter.PropertyStringFilter$MatcherUnion
WARN (tsgen) <ModelPlugin>: Component has no properties: dev.hilla.mappedtypes.OrderUnion
WARN (tsgen) <ModelPlugin>: Component has no properties: org.springframework.data.domain.Sort$DirectionUnion
WARN (tsgen) <ModelPlugin>: Component has no properties: org.springframework.data.domain.Sort$NullHandlingUnion

and then it fails with

[ERROR] frontend/generated/dev/hilla/crud/filter/FilterUnionModel.ts(3,16): error TS2304: Cannot find name 'FilterUnionModel'.

% cat frontend/generated/dev/hilla/crud/filter/FilterUnionModel.ts 
import { _getPropertyModel as _getPropertyModel_1 } from "@hilla/form";
import type FilterUnion_1 from "./FilterUnion.js";
export default FilterUnionModel;

[cromoteca]

You tried too fast ;)

[Lodin]

LGTM

[Lodin]

BTW, is it gonna be supported by EndpointInvoker runtime?

[cromoteca]

BTW, is it gonna be supported by EndpointInvoker runtime?

What support should be added? You'll send normal types anyway, never the union. It doesn't exist in Java.

[Lodin]

Yeah, I noticed that @type is not used by the model, so I was wondering about how it is supported on the Java end.

[cromoteca]

Jackson will handle it to create an instance of the right type in Java, so it is not part of the object.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

[vaadin-bot]

This ticket/PR has been released with Hilla 2.3.0.alpha6 and is also targeting the upcoming stable 2.3.0 version.