-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract client auth code in a library #1264
feat: extract client auth code in a library #1264
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
=======================================
Coverage 96.70% 96.70%
=======================================
Files 14 14
Lines 1698 1698
Branches 144 144
=======================================
Hits 1642 1642
Misses 56 56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some random initial comments about the module and not at all about the actual content. I had to do most of these changes to the react-grid module also
packages/ts/react-grid/src/types/dev/hilla/mappedtypes/Order.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Artur <[email protected]>
Co-authored-by: Artur <[email protected]>
a20c09c
to
64d2d53
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This ticket/PR has been released with Hilla 2.3.0.alpha5 and is also targeting the upcoming stable 2.3.0 version. |
Does this imply changes to the docs? Did we start planning this? |
Probably yes. The docs explain how to implement from scratch. It is probably easier to use the new package. But the first thing to do is to use this package in the Start (pre-release version). |
Ping @platosha |
Introduces a `@hilla/react-auth` package containing helpers for dealing with login, logout, retrieving auth state, and protecting routes.
Adds a NPM module which extracts some existing code from auth support in Starter and SSO Kit.
This will allow to simplify the creation of new applications.
Closes #1235