Skip to content

Commit 127c92c

Browse files
authored
refactor: Move ThemeUtils and CSSBundler to internal package (#22983)
They are not related the the frontend build
1 parent cb74c46 commit 127c92c

File tree

13 files changed

+15
-21
lines changed

13 files changed

+15
-21
lines changed

flow-server/src/main/java/com/vaadin/flow/component/internal/StyleSheetHotswapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@
4646
import com.vaadin.flow.hotswap.VaadinHotswapper;
4747
import com.vaadin.flow.internal.ActiveStyleSheetTracker;
4848
import com.vaadin.flow.internal.AnnotationReader;
49+
import com.vaadin.flow.internal.CssBundler;
4950
import com.vaadin.flow.internal.FrontendUtils;
5051
import com.vaadin.flow.server.AppShellRegistry;
5152
import com.vaadin.flow.server.VaadinService;
5253
import com.vaadin.flow.server.VaadinSession;
53-
import com.vaadin.flow.server.frontend.CssBundler;
5454
import com.vaadin.flow.server.startup.ApplicationConfiguration;
5555
import com.vaadin.flow.shared.ApplicationConstants;
5656
import com.vaadin.flow.shared.ui.Dependency;

flow-server/src/main/java/com/vaadin/flow/server/frontend/CssBundler.java renamed to flow-server/src/main/java/com/vaadin/flow/internal/CssBundler.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* License for the specific language governing permissions and limitations under
1414
* the License.
1515
*/
16-
package com.vaadin.flow.server.frontend;
16+
package com.vaadin.flow.internal;
1717

1818
import java.io.File;
1919
import java.io.IOException;
@@ -31,9 +31,6 @@
3131
import org.slf4j.LoggerFactory;
3232
import tools.jackson.databind.JsonNode;
3333

34-
import com.vaadin.flow.internal.JacksonUtils;
35-
import com.vaadin.flow.internal.StringUtil;
36-
3734
/**
3835
* Utility methods to handle application theme CSS content.
3936
* <p>

flow-server/src/main/java/com/vaadin/flow/server/frontend/ThemeUtils.java renamed to flow-server/src/main/java/com/vaadin/flow/internal/ThemeUtils.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* License for the specific language governing permissions and limitations under
1414
* the License.
1515
*/
16-
package com.vaadin.flow.server.frontend;
16+
package com.vaadin.flow.internal;
1717

1818
import java.io.File;
1919
import java.io.IOException;
@@ -33,9 +33,6 @@
3333
import tools.jackson.databind.JsonNode;
3434

3535
import com.vaadin.flow.component.page.AppShellConfigurator;
36-
import com.vaadin.flow.internal.FileIOUtils;
37-
import com.vaadin.flow.internal.FrontendUtils;
38-
import com.vaadin.flow.internal.JacksonUtils;
3936
import com.vaadin.flow.server.AbstractConfiguration;
4037
import com.vaadin.flow.server.AppShellRegistry;
4138
import com.vaadin.flow.server.Constants;

flow-server/src/main/java/com/vaadin/flow/server/BootstrapHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,11 @@
6767
import com.vaadin.flow.function.DeploymentConfiguration;
6868
import com.vaadin.flow.internal.AnnotationReader;
6969
import com.vaadin.flow.internal.BootstrapHandlerHelper;
70+
import com.vaadin.flow.internal.CssBundler;
7071
import com.vaadin.flow.internal.FrontendUtils;
7172
import com.vaadin.flow.internal.JacksonUtils;
7273
import com.vaadin.flow.internal.ReflectTools;
74+
import com.vaadin.flow.internal.ThemeUtils;
7375
import com.vaadin.flow.internal.UsageStatisticsExporter;
7476
import com.vaadin.flow.router.InvalidLocationException;
7577
import com.vaadin.flow.router.Location;
@@ -79,9 +81,7 @@
7981
import com.vaadin.flow.server.communication.IndexHtmlRequestHandler;
8082
import com.vaadin.flow.server.communication.PushConnectionFactory;
8183
import com.vaadin.flow.server.communication.UidlWriter;
82-
import com.vaadin.flow.server.frontend.CssBundler;
8384
import com.vaadin.flow.server.frontend.DevBundleUtils;
84-
import com.vaadin.flow.server.frontend.ThemeUtils;
8585
import com.vaadin.flow.server.startup.ApplicationConfiguration;
8686
import com.vaadin.flow.shared.ApplicationConstants;
8787
import com.vaadin.flow.shared.VaadinUriResolver;

flow-server/src/main/java/com/vaadin/flow/server/StaticFileServer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@
4848
import com.vaadin.flow.internal.DevModeHandlerManager;
4949
import com.vaadin.flow.internal.FrontendUtils;
5050
import com.vaadin.flow.internal.ResponseWriter;
51+
import com.vaadin.flow.internal.ThemeUtils;
5152
import com.vaadin.flow.server.frontend.DevBundleUtils;
52-
import com.vaadin.flow.server.frontend.ThemeUtils;
5353

5454
import static com.vaadin.flow.server.Constants.VAADIN_MAPPING;
5555
import static com.vaadin.flow.server.Constants.VAADIN_WEBAPP_RESOURCES;

flow-server/src/main/java/com/vaadin/flow/server/communication/IndexHtmlRequestHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
import com.vaadin.flow.internal.FrontendUtils;
5454
import com.vaadin.flow.internal.JacksonUtils;
5555
import com.vaadin.flow.internal.LocaleUtil;
56+
import com.vaadin.flow.internal.ThemeUtils;
5657
import com.vaadin.flow.internal.UsageStatisticsExporter;
5758
import com.vaadin.flow.internal.springcsrf.SpringCsrfTokenUtil;
5859
import com.vaadin.flow.server.AbstractConfiguration;
@@ -67,7 +68,6 @@
6768
import com.vaadin.flow.server.VaadinService;
6869
import com.vaadin.flow.server.VaadinServletContext;
6970
import com.vaadin.flow.server.VaadinSession;
70-
import com.vaadin.flow.server.frontend.ThemeUtils;
7171
import com.vaadin.flow.server.startup.ApplicationConfiguration;
7272
import com.vaadin.flow.shared.ApplicationConstants;
7373

flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskProcessStylesheetCss.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.slf4j.LoggerFactory;
2626

2727
import com.vaadin.flow.component.dependency.StyleSheet;
28+
import com.vaadin.flow.internal.CssBundler;
2829
import com.vaadin.flow.server.frontend.scanner.ClassFinder;
2930

3031
/**

flow-server/src/main/java/com/vaadin/flow/server/frontend/ThemeValidationUtil.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
import com.vaadin.flow.internal.FileIOUtils;
4343
import com.vaadin.flow.internal.JacksonUtils;
4444
import com.vaadin.flow.internal.StringUtil;
45+
import com.vaadin.flow.internal.ThemeUtils;
4546
import com.vaadin.flow.server.Constants;
4647
import com.vaadin.flow.server.frontend.scanner.FrontendDependenciesScanner;
4748
import com.vaadin.flow.theme.ThemeDefinition;

flow-server/src/test/java/com/vaadin/flow/server/frontend/CssBundlerTest.java renamed to flow-server/src/test/java/com/vaadin/flow/internal/CssBundlerTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* License for the specific language governing permissions and limitations under
1414
* the License.
1515
*/
16-
package com.vaadin.flow.server.frontend;
16+
package com.vaadin.flow.internal;
1717

1818
import java.io.File;
1919
import java.io.IOException;
@@ -27,8 +27,6 @@
2727
import tools.jackson.databind.JsonNode;
2828
import tools.jackson.databind.ObjectMapper;
2929

30-
import com.vaadin.flow.internal.JacksonUtils;
31-
3230
public class CssBundlerTest {
3331

3432
private static final String TEST_CSS = "body {background: blue};";

flow-test-generic/src/main/java/com/vaadin/flow/testutil/ClassesSerializableTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ protected Stream<String> getExcludedPatterns() {
240240
// Frontend tasks classes which are not stored anywhere but used
241241
// only once
242242
"com\\.vaadin\\.flow\\.server\\.frontend\\.scanner\\..*",
243-
"com\\.vaadin\\.flow\\.server\\.frontend\\.CssBundler",
243+
"com\\.vaadin\\.flow\\.internal\\.CssBundler",
244244
"com\\.vaadin\\.flow\\.server\\.frontend\\.FrontendTools",
245245
"com\\.vaadin\\.flow\\.server\\.frontend\\.JarContentsManager",
246246
"com\\.vaadin\\.flow\\.server\\.frontend\\.VersionsJsonConverter",

0 commit comments

Comments
 (0)