Commit 022aea9
committed
refactor: Make flow-build-tools dependency provided/optional in Maven plugin ITs
Make flow-build-tools dependency provided and optional in integration tests
to prevent it from being picked up by ClassFinder as a project dependency.
This better simulates real application projects which don't typically depend
on build tools directly.
Changes:
- Add provided+optional scope to 6 ITs that implement TypeScriptBootstrapModifier:
- classfinder-lookup
- resources-from-project
- deps-with-classifier-dups-project
- plugin-pinned-deps-project
- commercial-banner-build
- ignore-maven-deps-from-project
- Remove flow-build-tools dependency entirely from frontend-scanner-tuning-project
(doesn't implement TypeScriptBootstrapModifier and doesn't need the dependency)
All ITs pass successfully with these changes.1 parent f94e851 commit 022aea9
File tree
7 files changed
+12
-6
lines changed- flow-plugins/flow-maven-plugin/src/it
- classfinder-lookup
- commercial-banner-build
- deps-with-classifier-dups-project
- frontend-scanner-tuning-project
- ignore-maven-deps-from-project
- plugin-pinned-deps-project
- resources-from-project
7 files changed
+12
-6
lines changedLines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
| |||
Lines changed: 0 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | 34 | | |
41 | 35 | | |
42 | 36 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
37 | 39 | | |
38 | 40 | | |
39 | 41 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
0 commit comments