Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden Grid Column should not run code #6737

Open
sveinnetnordic opened this issue Oct 22, 2024 · 1 comment · May be fixed by #6798
Open

Hidden Grid Column should not run code #6737

sveinnetnordic opened this issue Oct 22, 2024 · 1 comment · May be fixed by #6798
Assignees
@ugur-vaadin
Labels
performance vaadin-grid

Comments

@sveinnetnordic
Copy link

sveinnetnordic commented Oct 22, 2024 •
edited by DiegoCardoso
Loading

Description

Hidden column should not slow down grid

Expected outcome

Not run code that does nothing

Minimal reproducible example

grid.addColumn(this::getRemoteStatus).setHeader("Remote status").setVisible(false);

Steps to reproduce

getRemoteStatus() that sleeps

Environment

24.5.0

Browsers

Issue is not browser related
@rolfsmeds
Copy link
Contributor

Let's check how big of a refactoring this would be, and whether it may have undesired side-effects.

@ugur-vaadin ugur-vaadin self-assigned this Oct 25, 2024
@ugur-vaadin ugur-vaadin linked a pull request Nov 7, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ugur-vaadin ugur-vaadin

Labels
performance vaadin-grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add generate data when hidden api for column vaadin/flow-components
3 participants
@rolfsmeds @ugur-vaadin @sveinnetnordic