Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppLayout docs improvements #3984

Merged
merged 11 commits into from
Dec 11, 2024
Merged

AppLayout docs improvements #3984

merged 11 commits into from
Dec 11, 2024
+182 −31

Conversation

rolfsmeds
Copy link
Contributor

@rolfsmeds rolfsmeds commented Dec 7, 2024 •
edited
Loading

Fixes #3956

  • Added clearer descriptions of each layout area
  • Added section describing usage as root layout in Flow and Hilla

@github-actions github-actions bot added the Language unchecked English language check has not been done label Dec 7, 2024
sissbruecker
sissbruecker reviewed Dec 9, 2024
View reviewed changes
articles/components/app-layout/index.adoc Outdated Show resolved Hide resolved
articles/components/app-layout/index.adoc Outdated Show resolved Hide resolved
articles/components/app-layout/index.adoc Outdated Show resolved Hide resolved
@russelljtdyer russelljtdyer added Language checking English language checking is in progress and removed Language unchecked English language check has not been done labels Dec 11, 2024
@russelljtdyer russelljtdyer added Language checked English language check done and removed Language checking English language checking is in progress labels Dec 11, 2024
@russelljtdyer russelljtdyer merged commit 85b1472 into latest Dec 11, 2024
3 of 4 checks passed
@russelljtdyer russelljtdyer deleted the docs/applayoit-improvements branch December 11, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker left review comments

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees

@DiegoCardoso DiegoCardoso

@marcushellberg marcushellberg

@web-padawan web-padawan

@LawrenceDLockhart LawrenceDLockhart

Labels
Language checked English language check done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify role of AppLayout as root layout, link to relevant framework docs
7 participants
@rolfsmeds @DiegoCardoso @sissbruecker @marcushellberg @russelljtdyer @web-padawan @LawrenceDLockhart