Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for config parameter that excludes Vaadin components from package.json #3906

Open
mshabarov opened this issue Nov 12, 2024 · 0 comments · May be fixed by #3922
Open

Docs for config parameter that excludes Vaadin components from package.json #3906

mshabarov opened this issue Nov 12, 2024 · 0 comments · May be fixed by #3922
Assignees
Labels

Comments

@mshabarov
Copy link
Contributor

Tell us about your request

Add docs for how to use vaadin/flow#19948 and what it does.

Add the following limitations:

  • Flow apps will not compile with the setting on. Likely with some random "import not found" error.
  • Copilot will not work
  • If Hilla or some other part adds a package that depends on our components, the feature will stop working and all web components will be imported again. Flow manually excludes @vaadin/hilla-react-crud.

The feature description (javadoc) could have some kind of warning. It would also be good to mention that the feature excludes Vaadin components. Currently it says "Whether to include web component npm packages" which sound quite much broader than what it does.


If you think this issue is important, add a 👍 reaction to help the community and maintainers prioritize this issue.

@mshabarov mshabarov added the flow label Nov 12, 2024
@mshabarov mshabarov moved this to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Nov 12, 2024
@tltv tltv self-assigned this Nov 18, 2024
@tltv tltv moved this from 🟢Ready to Go to ⚒️ In progress in Vaadin Flow ongoing work (Vaadin 10+) Nov 18, 2024
@tltv tltv linked a pull request Nov 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔎Iteration reviews
Development

Successfully merging a pull request may close this issue.

2 participants