-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The graph's incremental update seems not support vertex property's update #1601
Comments
Oh, my fault. I'm sorry for the noisy. Reopned. |
Technically we can, but we define vineyard's objects as immutable objects (to make concurrency control simpler). The incremental update APIs are designed for bulk data loading as well. We currently only support adding to make multi-versioned immutable objects simpler. For scenarios like continuous incremental graph updating, I would like to suggest GART which is a graph store that supports streaming updates and more suitable for your cases like updating properties (via updating records in tables). GART is built upon vineyard as well. |
OK, I see, thanks for your reply. |
It can be implemented by
As the first step, we could support only vertices or edges part. |
I may not have enough bandwidth on Vineyard in the next two months. Would you folks @songqing (or @SighingSnow) like to implement such features? |
OK, thanks, it's not an urgent issue, I'll have a try later. |
Hi, could you please check this code block https://github.com/v6d-io/v6d/blob/main/modules/graph/loader/basic_ev_fragment_loader_impl.h#L344~L406. The code block mentioned is to use the origin data. We check the incremental added vertices, and if there is a duplicate, we use the origin table data deliberately. So if this property is needed, you can revise the code above to update the table data. @siyuan0322 could you please evaluate this issue |
Yeah, seems it's a good fit here. |
Yes, based on the current implementation, there only need small change to solve this issue. |
Describe your problem
#1563 has supported graph data's incremental update, however, it seems vertex property can not update, for example,
the full data is:
vid value
1 2.0
2 3.0
and the inc data is:
vid value
1 4.0
After inc update, the vid 1's value is 2.0 not 4.0
So, can we support vertex property's update?
The text was updated successfully, but these errors were encountered: