New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid generating client IDs in substrate #56

Open

slawo opened this issue Mar 18, 2019 · 0 comments

slawo commented Mar 18, 2019

substrate/natsstreaming/nats_streaming.go

Line 173 in 67626b3

clientID = c.QueueGroup + generateID()

This type of convenience can introduce unwanted behaviour upon re-connections and should not be silently ignored.

It is preferable for the client to generate its own random id when the user is aware of the consequences.

thinktainer mentioned this issue

[suggestion] [nats-streaming] Expose durable connection parameter #60

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment