Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter to expand reports when retrieving checks #33

Open
hsyed opened this issue May 12, 2019 · 1 comment
Open

Add parameter to expand reports when retrieving checks #33

hsyed opened this issue May 12, 2019 · 1 comment

Comments

@hsyed
Copy link
Contributor

hsyed commented May 12, 2019 •
edited
Loading

The get requests contain a query param to expand the check. When a check has the consider status the reports need to be expanded to make decisions.

The signature of GetCheck will need to be changed it should probably be updated to take a request object. Will you accept a PR for this ?
@hsyed
Copy link
Contributor Author

hsyed commented May 13, 2019

I missed GoCheckExpanded. This method loops over the reports and retrieves them in separate calls.

@hsyed hsyed changed the title Add parameters to expand reports when retrieving checks Add parameter to expand reports when retrieving checks May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsyed