Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential crash consistency bug in unlink #22

Open
paulwedeck opened this issue Oct 11, 2023 · 0 comments · May be fixed by #23
Open

Potential crash consistency bug in unlink #22

paulwedeck opened this issue Oct 11, 2023 · 0 comments · May be fixed by #23

Comments

@paulwedeck
Copy link

Hello,
I discovered a similar bug to #20 but in the unlink operation.
If unlink fails after the inode has been written to the truncate list, the truncate list recovery code will "truncate" the file to its former size.
During this operation, it updates the file timestamp.

I think this is invalid because this is neither the original nor the intended final state.
My fix works by only truncating the file if the new size is different from the old size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant