-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast write path timestamp bug #18
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I discovered another bug in the fast write path.
The bug occurs when modifying existing file contents if the region does not cross page bounds and the file system is in relaxed mode.
In this case, the file timestamp is only written after the data.
Therefore, crash states are possible where the data has been modified but the timestamp stays the same.
I think the most reasonable way to fix this is to move the timestamp update before the data update.
In this case, it is possible that the file is unmodified but the timestamp has been updated.
However, I think a too young timestamp is better than a too old one.
Otherwise, we could just permanently disable the fast write path but I think this is somewhat of an overreaction.
The text was updated successfully, but these errors were encountered: