Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Disable Reason in Result Window #25

Open
simasch opened this issue Feb 7, 2022 · 5 comments
Open

Show Disable Reason in Result Window #25

simasch opened this issue Feb 7, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@simasch
Copy link
Member

simasch commented Feb 7, 2022

utPLSQL adds a reason to a disabled test: utPLSQL/utPLSQL#610

Add the reason to the result window if the test is disabled.

@jgebal
Copy link
Member

jgebal commented Feb 7, 2022

Currently the ut_realtime_reporter is producing following output with disabled flag:

<test>
    <disabled>true</disabled>
</test>

If test is not disabled we get the following outcome.

<test>
    <disabled>false</disabled>
</test>

To keep backward compatibility we should not change that behaviour and add another flag.
I suggest introduction of <disabled_reason><![CDATA[Disabled reason description]]></disabled_reason>

So the results would be one of:

  • Disabled without reason
<test>
    <disabled>true</disabled>
</test>
  • Disabled with reason
<test>
    <disabled>true</disabled>
    <disabled_reason><![CDATA[the reason]]></disabled_reason>
</test>
  • Enabled
<test>
    <disabled>false</disabled>
</test>

@jgebal
Copy link
Member

jgebal commented Feb 7, 2022

@lwasylow
Copy link
Member

lwasylow commented Feb 7, 2022

I allowed myself to correct your post @jgebal as the word fale got me really confused :P
I totally agree that a new flag called disabled_reason would be best way.

@PhilippSalvisberg
Copy link
Member

I explained in utPLSQL/utPLSQL#1192 why I would use CamelCase and name the node disabledReason. IMO the next step is to implement the change outlined there.

@PhilippSalvisberg
Copy link
Member

Version 1.4.0 of the SQLDev extension can show the disabled reason. Here's a screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants