Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REMINDER] The DioptraClient support for file uploads via the post method needs testing coverage #712

Open
jkglasbrenner opened this issue Jan 15, 2025 · 0 comments
Labels
test Additions or changes to project tests waiting Has one or more action items that need to be addressed by another contributor or stakeholder

Comments

@jkglasbrenner
Copy link
Collaborator

The new files and data arguments for the DioptraClient's post method that were introduced in PR #708 do not have proper tests. This issue is a reminder/check that we need to make sure that it gets proper testing coverage after we add integration tests for REST API endpoints that will accept file uploads, e.g. #575, #588.

In the meantime, the following branch https://github.com/usnistgov/dioptra/tree/test-client-uploading-support serves as a sanity check that the new file uploading support works as expected. This branch adds a simple /echoes endpoint to the REST API that allows you to upload files, and the server echoes back the name and size of the files you upload. The branch also contains a simple integration test exercising the /echoes endpoint. Both the requests-based client and the one based on Flask test client work as expected. The basic logic in that branch may be adapted for building tests in #575 and #588.

@jkglasbrenner jkglasbrenner added test Additions or changes to project tests waiting Has one or more action items that need to be addressed by another contributor or stakeholder labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Additions or changes to project tests waiting Has one or more action items that need to be addressed by another contributor or stakeholder
Projects
None yet
Development

No branches or pull requests

1 participant