You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The specific use case I encountered this on was when forgetting to upload a needed plugin file that doesn't have any task plugins in it. (The plugin file contained functions required for other task plugins to run, but did not contain any task plugins itself). In this case, instead of printing an error along the lines of "this file could not be found" for importing functions from, it prints Package ____ does not exist, where the package it refers to is the folder that should contain the forgotten file.
In the past, I believe we did not run into this at all because we uploaded the entire folder as a zip file, so forgetting files was pretty much impossible. Now that we upload them one at a time through the web interface this is more likely to occur and the actual import error should probably be bubbled up to somewhere. The V1 python client can probably avoid this issue by continuing to upload every python file in the directory (instead of what I was doing, which was only selecting files containing task plugins referenced in the specific YML entrypoint.
The text was updated successfully, but these errors were encountered:
The specific use case I encountered this on was when forgetting to upload a needed plugin file that doesn't have any task plugins in it. (The plugin file contained functions required for other task plugins to run, but did not contain any task plugins itself). In this case, instead of printing an error along the lines of "this file could not be found" for importing functions from, it prints
Package ____ does not exist
, where the package it refers to is the folder that should contain the forgotten file.Here is where the issue occurs:
https://github.com/usnistgov/dioptra/blob/main/src/dioptra/pyplugs/_plugins.py#L303
In the past, I believe we did not run into this at all because we uploaded the entire folder as a zip file, so forgetting files was pretty much impossible. Now that we upload them one at a time through the web interface this is more likely to occur and the actual import error should probably be bubbled up to somewhere. The V1 python client can probably avoid this issue by continuing to upload every python file in the directory (instead of what I was doing, which was only selecting files containing task plugins referenced in the specific YML entrypoint.
The text was updated successfully, but these errors were encountered: