You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While #607 deals with default parameters in the parameters: section of the entrypoint YAML, this is for default literal values of inputs within the task graph. From what I can tell, at least some of these inputs are processed properly, as integers do seem to show up as integers.
For example, this correctly processes .01 and 5 as a float and an integer respectively:
However, when I read this in from the YAML file on the client side via python, the null in YAML becomes None in python, which when uploaded to the RESTAPI becomes "None":
In this example, subset does not throw a validation error because it is typed as union: [string, "null"] (so string is a valid type), but validation_split is typed as union: [number, "null"], so the validation fails, but both are ultimately wrong as neither are None by the time it reaches the task engine.
I also tried with directly uploading a string "null", which just stays as a string "null" all the way through the task engine.
Long story short if we don't have one already I think there needs to be a way to specify nulls through strings, which seems to have been lost since we're no longer directly uploading the YAML file from the client to the worker.
The text was updated successfully, but these errors were encountered:
after more testing, I believe this was just the fault of uploading JSON-formatted yaml instead of uploading portions of the yaml file directly for the task graph.
I believe this is a separate bug from #607
While #607 deals with default parameters in the
parameters:
section of the entrypoint YAML, this is for default literal values of inputs within the task graph. From what I can tell, at least some of these inputs are processed properly, as integers do seem to show up as integers.For example, this correctly processes
.01
and5
as afloat
and aninteger
respectively:However, when I read this in from the YAML file on the client side via python, the
null
in YAML becomesNone
in python, which when uploaded to the RESTAPI becomes"None"
:In this example,
subset
does not throw a validation error because it is typed asunion: [string, "null"]
(so string is a valid type), butvalidation_split
is typed asunion: [number, "null"]
, so the validation fails, but both are ultimately wrong as neither areNone
by the time it reaches the task engine.I also tried with directly uploading a string
"null"
, which just stays as a string"null"
all the way through the task engine.Long story short if we don't have one already I think there needs to be a way to specify nulls through strings, which seems to have been lost since we're no longer directly uploading the YAML file from the client to the worker.
The text was updated successfully, but these errors were encountered: