Save and reload form #653
Merged
Save and reload form #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
keithmanville
requested changes
Oct 21, 2024
There was a problem hiding this comment.
When navigating away from the create form, it warns me that I will lose my data. I hit confirm. When I navigate back it offers to fill in my previous inputs.
I think we should drop the warning when navigating away since my inputs are recoverable.
I was testing this for experiments
@keithmanville ok just pushed the change. When leaving a create form, it will temp save and leave without warning the user. |
This commit adds functionality to temporarily save and restore form functionality. When navigating away from an edit form, a popup should warn the user that their modifications will be lost (unless the user made no changes or hit cancel) When navigating away from a create form, the data should be preserved for the remainder of the current session, so when the user navigates back, they have the option of reloading or discarding their un-saved values. Job forms are temporarily saved in a experiment context, meaning that a saved job form for Experiment A have no effect on the job forms for experiment B. Similarly, plugin files are saved in a plugin context. If a saved form contains resource selections (entrypoints, queues, plugins) that have since been deleted, those values will not be re-loaded into the form.
keithmanville
force-pushed
the
save-form
branch
from
1ff4b7d
to
cda8799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating away from an edit form, a popup should warn the user that their modifications will be lost (unless the user made no changes or hit cancel)
When navigating away from a create form, the data should be preserved for the remainder of the current session, so when the user navigates back, they have the option of reloading or discarding their un-saved values.
Job forms are temporarily saved in a experiment context, meaning that a saved job form for Experiment A have no effect on the job forms for experiment B. Similarly, plugin files are saved in a plugin context.
If a saved form contains resource selections (entrypoints, queues, plugins) that have since been deleted, those values will not be re-loaded into the form.