Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.8 not reporting correct version #236

Open
mmccarl opened this issue Jul 16, 2024 · 3 comments
Open

v1.1.8 not reporting correct version #236

mmccarl opened this issue Jul 16, 2024 · 3 comments

Comments

@mmccarl
Copy link

mmccarl commented Jul 16, 2024

running ea_non_iid --version still reports v1.1.7 instead of v1.1.8

@AEGISOLVE-TEAM
Copy link

Any update on this issue.
Pulled the latest code - and up to date with master branch.
$ git branch --contains v1.1.8
* master
$ git status
On branch master
Your branch is up to date with 'origin/master'.

However ea_non_iid --version is reporting v1.1.7 and not v1.1.8
$ ./ea_non_iid --version
noniid 1.1.7

@joshuaehill
Copy link
Contributor

This is due to the macro in cpp/shared/utils.h:

#define VERSION "1.1.7"

This just needs to be updated to "1.1.8" for this version, but the next version (1.1.9?) will need to update to that. This value needs to be manually updated for each release, so it's pretty easy to overlook.

@locksmithone
Copy link
Contributor

I created a pull request to update that version number, perhaps this way is faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants