Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple ParallelHash MCT issues #212

Open
markowitz-isc opened this issue Jun 5, 2022 · 3 comments
Open

multiple ParallelHash MCT issues #212

markowitz-isc opened this issue Jun 5, 2022 · 3 comments

Comments

@markowitz-isc
Copy link

markowitz-isc commented Jun 5, 2022

vsId
PARALLELHASH-128-1.0/prompt.json and PARALLELHASH-256-1.0/prompt.json

Description of Problems

  1. Several of the ParallelHash MCT test group properties appearing in these sample prompt files are not defined in the spec (draft-celi-acvp-xof.html#name-test-groups): minBlockSize, maxBlockSize, minOutLen, and maxOutLen. As they appear to simply echo capabilities registration properties, they're probably unnecessary here.
  2. OTOH, they're referenced in the ParallelHash MCT pseudocode so it's not clear whether they're supposed to be hardcoded in the IUT or read from the prompt file.
  3. The server seems to ignore the MCT test case blocksize property (which strangely enough can be larger than maxBlockSize) and instead uses the group's minBlockSize (as specified in the pseudocode!)... which makes one wonder why there's a blocksize test case property at all. (See draft-celi-acvp-xof.html#name-parallelhash-monte-carlo-te.)
@livebe01
Copy link
Collaborator

livebe01 commented Aug 9, 2022

Sorry we haven't had a chance to get to this yet. Just letting you know that we haven't missed it.

@jbrock24
Copy link
Collaborator

Hi @markowitz-isc!

  1. These were missing and added to the docs late June. Thanks for letting us know!
  2. They are meant to be read on a per-case basis by the testing harness.
  3. The group's blocksize (a MathDomain object from registration) is used for the Generation's Hash method, the result's seed's BlockSize is saved to the TestCase as BlockSize (int) for use within the testing harness on a per-case basis.

@livebe01
Copy link
Collaborator

Reopening as item #3 appears to be valid

@livebe01 livebe01 reopened this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants